Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the fine-parallel-processing-work-queue.md task file to remove $ and remvoe text not appropiate for end user #12793

Merged
merged 1 commit into from
Feb 28, 2019

Conversation

DanyC97
Copy link
Contributor

@DanyC97 DanyC97 commented Feb 22, 2019

this PR address one task mentioned in #12740 which is

remove the section about

If you are working from the website source tree, you can go to the following directory and start a temporary Pod running Redis and a service so we can find it.

End user doesn't work from git repo

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 22, 2019
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Feb 22, 2019
@DanyC97
Copy link
Contributor Author

DanyC97 commented Feb 22, 2019

/assign @steveperry-53

@netlify
Copy link

netlify bot commented Feb 22, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 570902b

https://deploy-preview-12793--kubernetes-io-master-staging.netlify.com

@DanyC97
Copy link
Contributor Author

DanyC97 commented Feb 25, 2019

any help here with reviewing please ?

… $ and also remove text which is not appropiate for end user
@k8s-ci-robot k8s-ci-robot removed the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 26, 2019
@DanyC97 DanyC97 changed the title Update the fine-parallel-processing-work-queue.md task file to bring … Update the fine-parallel-processing-work-queue.md task file to remove $ and remvoe text not appropiate for end user Feb 26, 2019
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 26, 2019
@DanyC97
Copy link
Contributor Author

DanyC97 commented Feb 26, 2019

reduced the scope to keep it isolated as per @zacharysarah comment on another PR

@DanyC97
Copy link
Contributor Author

DanyC97 commented Feb 28, 2019

/assign @zparnold
/unassign @steveperry-53

@zparnold
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 28, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zparnold

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2019
@k8s-ci-robot k8s-ci-robot merged commit fb4c7d1 into kubernetes:master Feb 28, 2019
@DanyC97 DanyC97 deleted the tasks-job-fppwq branch February 28, 2019 11:05
kwiesmueller pushed a commit to kwiesmueller/website that referenced this pull request Feb 28, 2019
… $ and also remove text which is not appropiate for end user (kubernetes#12793)
krmayankk pushed a commit to krmayankk/kubernetes.github.io that referenced this pull request Mar 11, 2019
… $ and also remove text which is not appropiate for end user (kubernetes#12793)
yagonobre pushed a commit to yagonobre/website that referenced this pull request Mar 14, 2019
… $ and also remove text which is not appropiate for end user (kubernetes#12793)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants